Single acceptance test for ts plugin mode #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machty
force-pushed
the
acceptance-ts-plugin
branch
from
dce75c0 to
940479d
Compare
machty
force-pushed
the
acceptance-ts-plugin
branch
from
a7e6ab7 to
463b3ff
Compare
machty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our only mechanism for testing TS-Plugin-based diagnostics is to use acceptance tests. This PR introduces the necessary changes to get acceptance tests (mocha tests running within a VSCode window) running in TS Plugin mode working.
There are a number of issues with TS Plugin mode right now so there are a few hacks to get the (currently) singular acceptance test passing, but these hacks will be removed over time.